Dominik Moritz

Results 1544 comments of Dominik Moritz

Yes, Vega-Lite generates es2020 (https://github.com/vega/vega-lite/blob/4b5afa4118a021178933c006f585d64d9b9f7ea2/tsconfig.json#L3) for `module`. The bundles target current browser versions (https://github.com/vega/vega-lite/blob/4b5afa4118a021178933c006f585d64d9b9f7ea2/rollup.config.js#L71). Could you upgrade storybook? I think that's what we did in svelte-vega with success: https://github.com/vega/svelte-vega/blob/main/packages/storybook/package.json#L23.

Babel 7.8 supposedly supports it https://babeljs.io/blog/2020/01/11/7.8.0

Thanks for posting the fix for cra!

The missing transform issue usually happens when Vega is loaded twice.

You need to make sure to have a loader that supports esNext syntax.

I'll revert to es2015 in the next Vega-Lite release. Please use 5.0, not 5.1 for now.

I fixed the output in https://github.com/vega/vega-lite/pull/7595 btw. We are going back to es2015 for now.

I've actually manually set the config before to create a dark mode. It's actually pretty nice. ![image](https://user-images.githubusercontent.com/589034/62709641-09dbbd80-b9f6-11e9-955e-4601c05c39cb.png) You can find my code at https://github.com/uwdata/falcon/commit/8a9de43496842e62d883dc1e16b581e22ddfe678. However, I didn't extract the Vega...

Unfortunately, this change only would introduce backward-incompatible changes once we add support for theming. I don't plan to accept it into the main repo but you can use your fork...

Thank you for filing the issue. Yes, we have indeed not implemented support for the `-?`. Can you send a PR to implement it?