Dominik Moritz
Dominik Moritz
It's way more than that. How do users use datasets later? How do they manage versions? How do we share specs with data? This needs a lot of thought. I...
We have t set up any tests yet. I’d start with unit tests. Ideally we use jest since it’s already used in other projects in this org.
Do we meet the contrast ratio on hover or focus? If not, we should fix that. If yes, we can focus on the high contrast request case.
My idea was to add another action to the Vega-Embed actions, which is independent of Vega signals. See https://github.com/vega/vega-embed/blob/1fcb4389fd95e6025fc308a6b5af6b3c92660c97/src/embed.ts#L323
Closing since noone has asked for this yet.
Wanna send a pull request? I'm happy to help with reviews.
Yep, that would be cool. As a first step, you can get a markdown link. The editor already has a little link in the help dialog that sets the version....
We could try to send the state but I believe we cannot always serialize it. I'd certainly be open to a pull request. I won't have the time to work...
I will make a v7 release when we merge this.
Yes, I have seen this issue before but forgot to file an issue.