Dominik Moritz

icon indicating a website link https://www.domoritz.de icon indicating an email [email protected]

icon company CMU, Apple icon location Pittsburgh icon location Faculty at CMU (@cmudig) and researcher at @apple. PhD in Computer Science from the University of Washington (@uwdata, @uwdb). Co-creator @vega, @streamlit.

Results 1545 comments of Dominik Moritz

Reference types

Got it working with just wasm-bindgen-cli (see https://github.com/domoritz/arrow-wasm/tree/dom/reference-types) but the setup isn't fun and we need to validate the performance.

CSV and JSON reader

Yes, they do: https://docs.rs/arrow/3.0.0/arrow/csv/reader/struct.Reader.html and https://docs.rs/arrow/3.0.0/arrow/json/reader/struct.Reader.html.

at-loader outputs to file when webpack is run with --json

I'd say that this is a bug in atl, no?

Replace var with let or const as appropriate.

I think if the goal is to converge towards ES6, some internal inconsistency is fine. Maybe you can have something in the guidelines to ask people to gradually update to...

Replace var with let or const as appropriate.

Is the 1% more after or before gzip compression? To me, 1% more is a good trade off for safer code. Also, you could run Babel over the code to...

Replace var with let or const as appropriate.

Great. To me, that's within the noise.

Replace var with let or const as appropriate.

I sent one here: https://github.com/d3/d3-scale/pull/212 ;-)

Replace var with let or const as appropriate.

@lgrammel has been working on a bot that could automate a lot of the work.

Replace var with let or const as appropriate.

The final decision is with you of course. I just wanted to share my experience. Consistent code style (e.g. through automatic formatting) and splitting variable declarations (from one line for...

Detect renamed keys

Are you suggestions an `objectHash` method that ignores the key property? That's a great idea. How do I convert the data back to an object map afterwards and make sure...