dolio
dolio
Why not do the indicator in the same condition as the `item_condition_add`? Wouldn't that make it only show up while they're holding the weapon, and that's what you want?
`item_condition_add_with_args` adds a condition that is applied to whoever is holding the item. If you add tooltip hooks to that condition, won't it show up while the weapon is wielded...
If you're putting the duration on the `item_condition_add` thing, you should do some testing with removing and equipping it. I think any duration updates might only occur to the creature-applied...
It doesn't seem like the duration query for item conditions will work if there is more than one spell on the weapon that uses that system. It will just report...
Putting a tooltip hook on the spell condition that targets the item doesn't do anything, though. It has to be on the item wield condition for it to show up...
Sorry, by "weapon card" I mean the details you can see by clicking on the item appropriately in your inventory. You can see enhancement and keen and such there, but...
I looked through the omitted `Grappled` condition, and the only other discrepancy I saw is that it disables spellcasting. Technically this isn't quite right, but it it'd be a lot...
Tripping doesn't seem to have the text about the AoO stopping the attempt like grapple and disarm do. It just says you take an AoO because it counts as an...
Some of these functions do their own version of `tryEval`, essentially. Now that we have the latter, we could walk back some of them.
This would work with the current ability implementation. But if we ever switch to a system where ability usage corresponds to under-the-hood information passing, then these `coerceAbilities` don't actually make...