dnqbob

Results 197 comments of dnqbob

We use WithShadow to render a shadow right on the ground, not just at the actor place. I will show you an example of extra shadow problem.

![2shad](https://github.com/OpenRA/OpenRA/assets/13763394/31250287-2fbc-4eb3-b6ee-19c6179469a6) As you see the Carryall render shadow of passenger in the mid-air, and there is also a shadow of passenger rendered on the ground by WithShadows. It is no...

And this is what happens when we apply this PR: ![1shad](https://github.com/OpenRA/OpenRA/assets/13763394/0f76b9fb-69c2-4b55-8223-9c7611cc6fd2)

>Why? We do want to render the shadow…? In any case, our Carryall must be Aircraft, their shadow together with passenger's shadow will all be done by WithShadows.

@pchote ![2shad](https://github.com/OpenRA/OpenRA/assets/13763394/fe0a3d73-90ea-45a6-af3e-ee0ce713184d)

> it used to work properly without this change For god's sake, you can test it at 5cc1405f, I have seen this bug since 2021. ![2shad-old](https://github.com/OpenRA/OpenRA/assets/13763394/c4817e38-1eb3-4c69-9a33-087f21640c47) This is an old...

> its not the only regression (voxels no longer follow the rotation of the carryall) suggesting that the bug may be somewhere else Voxels shouldn't be related to this issue,...

I have to say I don't know, https://github.com/OpenRA/OpenRA/issues/20603 is a rare crash happens only when exit a game scene, which is hard to debug.

I think you can do this later, because devs in https://github.com/OpenRA/OpenRA/issues/20693 may have plan to split "en.ftl".

It is mainly because TS aircraft does not have vision. `AttackAircraft` cannot attack actor that is under shroud for AI.