Daniel Nephin
Daniel Nephin
Done in #288 and #283
Thank you for working on this! The failure in `TestDebugCommand` is surprising. Somehow it seems the arm image uses a different `umask`. I'm not sure why that would be. Maybe...
Looks great! I think we might ask to remove the `dev-build-arm64` job, since we are building the arm64 binary in github actions already: https://github.com/hashicorp/consul/runs/4398280894?check_suite_focus=true
Oh, ya if we need it for the testing then I guess we need the CI job as well. Please do open a PR with these changes, thank you!
@bukzor that's what I proposed here: #28 (comment) dcgc already supports a file based exclude list. Whatever writes the events to disk should be able to write just the image...
I see what you're saying. It still feels a little weird to have `dcgc` read an event stream from a file, but I guess it's more reliable. So I guess...
> If the junit report contains failures, then the CI system will interpret those as failures, marking the CI job as failed instead of passed. Interesting! Which CI system is...
I'd like to help you find a solution to this problem, but I'm not keen on maintaining a feature that requires knowledge of the coverage profile (even if it calls...
If it doesn't work that way it's possible that the logic for merging profiles will be involved than what `gocovmerge` supports. I suspect that tool is for merging separate package...
Ah, yes I did miss that, I had not realized you had it all working! That's awesome! So the problem left to solve is making it easier to use, is...