Daniel Nephin

Results 312 comments of Daniel Nephin

Thank you for the bug report! Looking at this test, I believe what's happening is that we use https://pkg.go.dev/time#Time.Truncate to split time into intervals. If some of the test data...

``` python client.start(container) pty.start(sockets) ``` This seems like a potential race, right? Logs can be missed if they are printed before the `pty.start()` connects. I'm not sure why it works...

Ah right, I forgot we worked that out. Thanks

I think you might want to copy some of the steps from the dockerpty suite. An important one is https://github.com/d11wtq/dockerpty/blob/master/features/steps/step_definitions.py#L74 `@when('I start dockerpty')`, which sets up the environment. It's been...

It's literally [forking](https://en.wikipedia.org/wiki/Fork_%28system_call%29), so your code would hit both branches, just in different processes (https://docs.python.org/2/library/pty.html#pty.fork) Check out the docs for subprocess (https://docs.python.org/2/library/subprocess.html#subprocess.Popen) > stdin, stdout and stderr ... Valid values...

The problem is not limited to just the interface check. If the interface uses any types defined in the same package for args or returns those types will cause the...

The generated fakes already store the list of calls, and they can be retrieved with `Fake.Invocations()`. Possibly related to #106

Looking into this I see that `Fake.Invocations()` can kind of be used for this purpose. It requires using the function name to index into the map, and use untyped `[]interface{}`...

I don't think this repo is being maintained. You can find the current version of this code at https://github.com/docker/cli/tree/master/cli/compose

I started working on this in https://github.com/aanand/compose-file/compare/master...dnephin:warn-on-ipv4addr, but it's unfortunately a lot more complicated than it sounds. We're comparing against the raw config types, so trying to access these nested...