Daniel Nephin

Results 443 comments of Daniel Nephin

I've added that test, and rebased to resolve the merge conflict.

> I'm assuming that the way deprecated routes will work is that we remove the route from the main routes, and then include the old route in addPreviousVersionHandlers(), which seems...

Could still be relevant if org admins use a separate admin account from their regular user account. Not sure how common that will be.

I think this may still be relevant. Admins may have multiple accounts per organization. Let's keep this around for a bit longer.

I wrote a custom plugin for `golangci-lint` recently and ran into all the same problems. I was able to script the module versions using the output of `go version -m`...

We merged some changes in #97 which I think had the same goal, so hopefully this problem is fixed now.

For those who may be interested: #98

It sounds like https://go-review.googlesource.com/c/go/+/443596 has probably fixed the issue, and that fix should be in the next go release (go1.20). Thank you for your work to get this issue fixed!...

> GitHub Actions will redact, but these test files would be raw output, I believe? I believe that's right

Ok, I've got this running again over at https://github.com/dnephin/infra/actions/workflows/ci-core.yaml I remove file pruning from `gotestsum tool ci-matrix`, it's easily done with ``` find /home/runner/reports/ -mindepth 1 -mtime +3 -delete ```...