Daniel Nephin
Daniel Nephin
Rebase and squash done!
No problem, all done!
Hey Glen! I think it would make sense to start using generics for `Equal` and `DeepEqual` at some point. I'm not sure if there are any other functions that would...
Nice! I like the idea of type-safe implementations like `cmp.ListContains` (maybe `cmp.SliceContains` and document that it also accepts arrays, since arrays tend to be much less common?), and `cmp.HasKey` !...
I put together #255 which adds generics to the main assertions, if you'd like to check it out. For `Contains` and `Len`, how often do you use those to check...
Sounds good! When this tool was first written modules didn't exist, but now I think it's a good idea to make it a separate module. I think at the same...
Thank you for the bug report! I think this would be good to fix. Similar to the bazel fix, would you be able to run the test with some environment...
@cstrahan Thank you for offering to fix this! The env var to specify the GO module directory seems like the safe and easy option. Thinking through some more: > Go...
Good point! Capturing the working directory from an `init` function seems good to me. I think it's fine to go with that approach for now. We can add an env...
Thanks for working on this! I tried the separate module in #268. I don't understand why only go1.19 is failing. I don't see anything different about that config. It should...