Daniel Nephin

Results 123 issues of Daniel Nephin

With the addition of labels in #54 only the new `WithLabels` methods on `Sink` are used by `go-metrics`. My understanding is that this should be a backwards compatible change, because...

There's still one piece missing from this workflow. At the very least, there needs to be a way to "docker push" all the images that are part of the composition....

enhancement

Since `docker-compose` is getting this support in 1.5, namespace may need to interpolate these variables as well, as part of the "export"

enhancement

I'm thinking a `DROP` token could signal that the service should be removed. Normally the service needs to be a mapping, so this should never be a valid value.

enhancement

I have been using counterfeiter with [gotest.tools/assert](https://godoc.org/gotest.tools/assert) which uses [go-cmp](https://godoc.org/github.com/google/go-cmp/cmp) to compare structs. I often find myself using `fake.FooArgsForCall(i)` and writing an assertion for each of the args. I would...

ipv4/6_address are not supported by swarmkit yet, but we don't warn when they are included in a file. cc @aanand @vdemeester

Related to #11347 Best viewed by individual commit. This PR removes the `CARoot.SigningKey` field, which was only ever used by tests. It also removes the use of `CARoot.SigningCert` in tests,...

theme/internal-cleanup
theme/connect
pr/no-changelog
backport/1.11

This PR adds a new function for property testing of operations that need to include all the fields on a struct. Common examples of functions that could be tested with...

Originally we thought there might be more stuff to include in the `skip` package. It has been a few years, and we haven't added anything. This PR deprecates the `skip`...