Dmitri Shuralyov
Dmitri Shuralyov
The `dom/v2` package uses `syscall/js` package to access the browser's DOM API. The `syscall/js` package is only available when building with `GOOS=js GOARCH=wasm` or with GopherJS (which uses `GOARCH=js`). I...
FWIW [maligned](https://github.com/mdempsky/maligned) was refactored to implement an `analysis.Analyzer` in https://github.com/mdempsky/maligned/commit/c37866e2d38b8e33600b215e4095af870becd4d8 so there's precedent, but I'd wait to hear from the package author.
Not sure if this is the same issue, or another but related one... `unconvert` is also missing opportunities to point out unnecessary conversion of nil slices: ```Go package main import...
Very good point about the distinction between typed vs untyped constants. I agree that supporting it would still be helpful, but being able to control this behavior via a flag...
I've confirmed, if I change the const in the original program from untyped string to typed string, by doing this: ```diff -const foo = "foo" +const foo string = "foo"...
> There may be another issue with just dealing with `Go-Package-Store` Is there an issue with Go Package Store itself, or is it an issue with how you have it...
CC @FiloSottile, @agl, @rsc per [owners](https://dev.golang.org/owners).
I suspect it's going to be quite difficult to get the confidence that making a breaking change as significant as this is going to be worth it at this point....
According to https://github.com/alecthomas/gometalinter/blob/0262fb20957a4c2d3bb7c834a6a125ae3884a2c6/linters.go#L373, it looks like `gometalinter` invokes `unconvert` without `-all` or any other flags.