Dmitri Shuralyov

Simpler fix for credentials with characters such as '/'.

2

Thanks for describing the problem in great detail in PR #39 @opalmer. I suspect there may be a much simpler fix, which I'd like to discuss. Consider this comment: https://github.com/andygrunwald/go-gerrit/blob/70bbb05ea8c6502189a73862f956dac687b91075/gerrit.go#L101-L104...

This code is not updated to use the latest x/mobile/gl API, is it?

1

It's a little misleading having this repo here. Perhaps you should mark it as out of date, update it, or remove it?

copyright holder mismatch between LICENSE and comment in smtpd.go

1

Compare: https://github.com/bradfitz/go-smtpd/blob/deb6d623762522f8ad4a55b952001e4215a76cf4/LICENSE#L1 https://github.com/bradfitz/go-smtpd/blob/deb6d623762522f8ad4a55b952001e4215a76cf4/smtpd/smtpd.go#L1 Is it intentional that they don't match?

smtpd: ability to stop the server

1

This is a feature request. I want to find out if it's in scope for this package. It'd be nice to be able to stop the `smtpd.Server`, similar to [`http.Server.Close`](https://godoc.org/net/http#Server.Close)...

The default branch of a git repository is its remote HEAD branch. In modern versions of Go, `go get` respects the default branch and uses it. I have a tool...

all: consider using golang.org/x/{mod,tools} packages and removing duplicates

7

Now that https://github.com/golang/go/issues/31761 has been accepted and golang.org/x/mod is starting to get some of the same packages, I think it would make sense to start using them in this repository...

The current latest release version [v1.5.2](https://github.com/russross/blackfriday/releases/tag/v1.5.2) doesn't include the fix for https://github.com/russross/blackfriday/issues/495. We should make a newer release version. /cc @rtfb See https://github.com/shurcooL/markdownfmt/issues/47#issuecomment-475999054 for context on where this came up.

goimports partially solves the need for gosloppy.

4

For example, consider the example: ``` Go package main import "fmt" func main() { println("no fmt, yet compiles") } ``` Using [`goimports`](http://godoc.org/code.google.com/p/go.tools/cmd/goimports) on that will remove the "fmt" import since...

x/tools/gopls/internal/regtest/misc: TestFailingDiagnosticClearingOnEdit failures with "context deadline exceeded"

1

There are instances of the `TestFailingDiagnosticClearingOnEdit` test failing with "context deadline exceeded": ``` --- FAIL: TestFailingDiagnosticClearingOnEdit (560.80s) --- FAIL: TestFailingDiagnosticClearingOnEdit/default (560.80s) failures_test.go:63: waiting on: Met: no diagnostics for "a.go" Unmet:...

cmd/compile/internal/test: TestAppendOfMake fails with GOEXPERIMENT=unified

3

Observed in trybots of CL 420234: ``` --- FAIL: TestAppendOfMake (0.00s) issue53888_test.go:29: got 1.000000 allocs, want 0 issue53888_test.go:41: got 1.000000 allocs, want 0 FAIL FAIL cmd/compile/internal/test 9.922s ``` (https://storage.googleapis.com/go-build-log/7622dec8/linux-amd64-unified_f57873d7.log) It...