Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

It makes sense for `glock` to do that. It would be inaccurate to save a dependency as a given revision when it has a dirty working tree - resulting in...

Since this issue is about the `github.com/gopherjs/gopherjs/build` API, it should be in the https://github.com/gopherjs/gopherjs/issues tracker. Do you mind moving it there? > we could decide to leave `github.com/gopherjs/gopherjs/build` as broken...

Thanks for reporting. Since the field is optional, `MaxObjectSizeLimitInfo` is definitely not right as it'll always be included despite the `omitempty` tag, while `*MaxObjectSizeLimitInfo` would allow the zero value to...

@andygrunwald It should be possible to infer the type from Gerrit's code. If [ProjectInput.java](https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:java/com/google/gerrit/extensions/api/projects/ProjectInput.java;l=39;drc=cdde7a309f2f8b27e3f34086b17217066daabf60) is the right place to look, then using `string` as implemented in PR #112 looks right...

More details. The code uses a few packages that have been removed or moved. ``` ~ $ go get -u github.com/crawshaw/gopher3d package github.com/crawshaw/gopher3d imports golang.org/x/mobile/app imports golang.org/x/mobile/geom imports golang.org/x/mobile/gl imports...

> servegoissues should really live in issuemirror, but oh well. If it's better, why don't we move it? I'm not opposed. Or do you mean that it's not worth the...

> I'd like to start mirroring a number of github project's issues so I could work with them all offline. That's very, very easy. > Is there anything Go-specific about...

A single `serveissues` (or whatever it's called) binary can also be made to serve issues from multiple projects at once. For that, you'll just need to change the URL scheme...

@bradfitz, in https://github.com/bradfitz/go-issue-mirror/pull/6#issuecomment-242926641 you said: > I'd actually prefer that this repo be purely data and no code, and servegoissues live in what was supposed to be the generic counterpart...