Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

> The only (minor) thing I would suggest is to shorten names of generated files. Why not to provide idiomatically laconic names, e.g. `.go` + `vfs.go`? I was worried about...

Has anyone considered the idea of minimum guaranteed income (basic income) as something that could enable more people to be able to work on open-source full time, at their own...

There's a func in the standard library to parse GOPATH variable (and any other env vars that are a list of paths joined by the OS-specific ListSeparator): https://godoc.org/path/filepath#SplitList

The commit that triggered CI was https://github.com/shurcooL/notifications/commit/5a67cc840e31516e2b2e1ab0b839ecb628ec56b9. It includes the following code: ```diff type Router interface { // IssueURL returns the HTML URL of the specified GitHub issue. - IssueURL(owner,...

> Thanks for the issue, I'll work on a fix for this. No problem, I'm happy if it's helpful. :) Thanks for describing what the issue appears to be, it's...

> The issue is the string in this case is: > > ```Go > package expr > type ExternalService interface{ > MarkRead(ctx context.Context, appID string, repo github.com/shurcooL/notifications.RepoSpec, threadID uint64) error;...

Oh, ok, gotcha. Yeah, that’s the latest. I just wanted to make sure the original issue wasn’t caused due to version skew.

They've been implemented as "type aliases" in Go 1.9: https://golang.org/doc/go1.9#language

Are you familiar with [`vcs.RepoRootForImportPath`](https://godoc.org/golang.org/x/tools/go/vcs#RepoRootForImportPath)?

Thanks for looking into this, it's a good start. > I will add a separate package `githubv4preview` One of the most difficult decisions we'll need to make before a change...