apicompat icon indicating copy to clipboard operation
apicompat copied to clipboard

Consider dropping import path support

Open bradleyfalzon opened this issue 9 years ago • 4 comments

It's not possible to determine ahead of time which VCS path for a given import path without adding more code.

It maybe simpler to not support checking import paths, and instead, only check the local directory and it's sub directories.

bradleyfalzon avatar Sep 01 '16 11:09 bradleyfalzon

Are you familiar with vcs.RepoRootForImportPath?

dmitshur avatar Sep 24 '16 16:09 dmitshur

I had trolled those repos looking for libraries to use/read, I can't recall why I didn't use them, will reinvestigate. But thanks for the reminder, I think it maybe useful in another related project.

bradleyfalzon avatar Sep 24 '16 23:09 bradleyfalzon

No we're good on this one, give me a couple hours

ghost avatar Oct 07 '16 18:10 ghost

TODO needs additional tests (see some discussion in #31, but mostly lack of coverage in new commits.

bradleyfalzon avatar Oct 08 '16 11:10 bradleyfalzon