Dmitri Shuralyov

Results 869 comments of Dmitri Shuralyov

> what's the usefulness of saving the modtime? Mostly to enable HTTP caching. When files have accurate modification times, and a request comes in with a `If-Modified-Since: Thu, 05 Jul...

Thanks for posting this this feature request. > It should be possible to compress the webroot directory with both gzip and brotli; store both versions in the generated assets.go file;...

> I tried adding path to `vfsgen.Options.Filename`, but it seems to be ignored by vfsgen. That shouldn't be the case. Can you show a snippet that reproduces this behavior?

Hi, thanks for the suggestion. > not sure if this is the best way of doing this. That's a reasonable way of doing it. I've also done this using the...

Yes, this is a limitation of `vfsgendev`. It generates Go code that imports the variable you specify, and since `main` packages cannot be imported, it can't work. I'm not sure...

That said, the error you got seems unrelated to the issue: ``` $ vfsgendev -source="".Assets -source flag has invalid value: invalid format, expression &{0xc42006aa80 18 / 0xc42005e2e0} is not a...

Ok, I can reproduce that error by running this in bash: ``` $ vfsgendev -source="foo/bar".baz -source flag has invalid value: invalid format, expression &{foo 4 / 0xc4200e2080} is not a...

Interesting. Perhaps I'm misremembering about inability to import `main` packages (i.e., commands). Maybe what's not possible to use is `go get` on packages that import commands... If importing a `main`...

> Interesting. Perhaps I'm misremembering about inability to import `main` packages (i.e., commands). Maybe what's not possible to use is `go get` on packages that import commands... Nope, I wasn't....

See my comment above. I tried renaming, it still doesn't work. Not with Go 1.9. It worked with older versions of Go (1.6 or so, I can't remember when exactly...