opentelemetry-go-contrib icon indicating copy to clipboard operation
opentelemetry-go-contrib copied to clipboard

Remove the deprecated `StreamServerInterceptor` function from `otelgrpc`

Open MrAlias opened this issue 7 months ago • 2 comments
trafficstars

This function was deprecated in the last year and should be removed.

  • [ ] Remove the deprecated UnaryServerInterceptor function: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/2a6af7def1f050f24f6739c8d45745eb3f3f2d95/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go#L393-L448
  • [ ] Remove the benchmark test: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/2a6af7def1f050f24f6739c8d45745eb3f3f2d95/instrumentation/google.golang.org/grpc/otelgrpc/benchmark_test.go#L81-L87
  • [ ] Remove tests:
    • https://github.com/open-telemetry/opentelemetry-go-contrib/blob/2a6af7def1f050f24f6739c8d45745eb3f3f2d95/instrumentation/google.golang.org/grpc/otelgrpc/test/interceptor_test.go#L982-L1110
    • https://github.com/open-telemetry/opentelemetry-go-contrib/blob/2a6af7def1f050f24f6739c8d45745eb3f3f2d95/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go#L119-L123
    • https://github.com/open-telemetry/opentelemetry-go-contrib/blob/2a6af7def1f050f24f6739c8d45745eb3f3f2d95/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go#L143-L145
    • https://github.com/open-telemetry/opentelemetry-go-contrib/blob/2a6af7def1f050f24f6739c8d45745eb3f3f2d95/instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go#L388-L569
  • [ ] Add a changelog entry in the ### Removed section of the unreleased changelog for the removal.

MrAlias avatar Apr 02 '25 14:04 MrAlias

Would like to work on this

tasdikrahman avatar Apr 02 '25 15:04 tasdikrahman

@tasdikrahman are you still working on this?

dmathieu avatar May 15 '25 07:05 dmathieu

@dmathieu i would like to work on this, can you assign me please?

ishaish103 avatar Jul 31 '25 02:07 ishaish103

@dmathieu @pellared
seems like this was already done (https://github.com/open-telemetry/opentelemetry-go-contrib/pull/7362) main doesnt contain that code anymore, this issue can be closed

ishaish103 avatar Jul 31 '25 16:07 ishaish103

@ishaish103 thanks for the help!

MrAlias avatar Jul 31 '25 17:07 MrAlias