Damien Mathieu
Damien Mathieu
Closing this per @MrAlias's comment, as this would be a breaking changes in both semver and the specification.
Could you fix the CI issues?
Could you add a test?
This will need a changelog entry. And we should have another PR in contrib fixing the failing tests.
Closing, as this has been superseded by #13245
This shouldn't be a public module. If we expect there will be more tests skipped on FIPS, it makes sense to have this as a module global to the collector....
It is. I think to fix the linter, you need to run `make gotidy`.
You need a replace statement so the testutil package properly points to the local path, not to a released package. ```diff diff --git a/confmap/go.mod b/confmap/go.mod index 35d3f3f81..426bbf6ba 100644 --- a/confmap/go.mod...
Were you able to explicitly confirm that the issue in https://github.com/open-telemetry/opentelemetry-collector/issues/11537 isn't reintroduced here?
I'm marking this as "ready to merge" based on the number of approvals. My comment about removing the test for go-grpc behavior is not a blocker.