Andrey Yegorov

Results 63 comments of Andrey Yegorov

@hangc0276 I rebased after the merge of downgrade compat tests; upgrade to 9.2.1 doesn't downgrade nicely. I am not yet sure what can be configured to support compatibility.

@Vanlightly @eolivelli I updated OrderedExecutor to better distribute data across the threads, added tests reproducing the issue. please take a look: https://github.com/apache/bookkeeper/pull/3023 This does not address the fact that generated...

@blankensteiner An author of https://github.com/apache/pulsar-dotpulsar/pull/263 reached to my management asking for review. Unfortunately, we don't have people with expertise in .NET and while the change looks ok on the first...

Please fix the checkstyle ``` [INFO] There are 6 errors reported by Checkstyle 9.3 with buildtools/src/main/resources/bookkeeper/checkstyle.xml ruleset. Error: src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongHashMapTest.java:[224,29] (whitespace) WhitespaceAfter: ',' is not followed by whitespace. Error: src/test/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMapTest.java:[41,1] (imports)...

Can you please provide more details for "(Explain: why you're making that change, what is the problem you're trying to solve)".

@lhotari some tests broke, e.g. ``` Error: Errors: Error: org.apache.bookkeeper.client.BookKeeperTest.testReadWriteWithV2WireProtocol Error: Run 1: BookKeeperTest.testReadWriteWithV2WireProtocol » BKNotEnoughBookies Not enough non-faulty bookies available Error: Run 2: BookKeeperTest.testReadWriteWithV2WireProtocol » BKNotEnoughBookies Not enough non-faulty...

CI is failing: ``` [INFO] Error: Errors: Error: org.apache.bookkeeper.client.TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter Error: Run 1: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer Error: Run 2: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer Error: Run 3: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer ```

Didn't look at his closely, fastthread.io says: ``` Thread pulsar-io-32-13 is in deadlock with thread pulsar-io-32-14 pulsar-io-32-13 THREAD ID : 191 STATE : BLOCKED stackTrace: owned by pulsar-io-32-14 Id=192 at...