pulsar-dotpulsar icon indicating copy to clipboard operation
pulsar-dotpulsar copied to clipboard

Implement peek and try peek for consumers

Open KasparRugholm opened this issue 1 year ago • 2 comments

Description

Implements peek functionality for consumers, to allow multiple access to a message.

Regression

No

Testing

The new methods of the consumer has been integration tested, and the underlying methods on the AsyncQueue has been unit tested.

KasparRugholm avatar Jan 14 '25 10:01 KasparRugholm

@dlg99 you have requested my review on 3 PRs, none of which are created by you and I am wondering why? Take this PR for instance, have you talked with the creator? Do you know if he feels the PR is ready to be reviewed? Hint: I work with him and know that this PR is not ready for review, but even if I didn't know I can see the branch has conflicts and that tells me that it is not ready for review.

blankensteiner avatar May 15 '25 20:05 blankensteiner

@blankensteiner An author of https://github.com/apache/pulsar-dotpulsar/pull/263 reached to my management asking for review. Unfortunately, we don't have people with expertise in .NET and while the change looks ok on the first glance I haven't touched .net in long time and never looked at the pulsar's .net client. I decided to request a review form an expert. I hope you have time to take a look, it is fairly small.

Other PRs just looked somewhat related to the missing client functionality. No bad intentions there. I understand that this project is an effort of a very small group of people busy with their day jobs, and wasn't sure of the status of the PRs, I was poking around the commits/PRs/issues trying to see how active the project is.

dlg99 avatar May 15 '25 23:05 dlg99