bookkeeper icon indicating copy to clipboard operation
bookkeeper copied to clipboard
verified publisher icon apache

Simplify the batching of V2 AddResponses

Open lhotari opened this issue 1 year ago • 2 comments

Motivation

The batching solution for V2 AddResponses doesn't seem natural for a Netty application. Batching can be implemented using the Netty Pipeline handlers instead. This avoids synchronization and avoids any possible ordering issues that could be caused when calls are entering in multiple ways.

Changes

  • Write the AddResponses to the Netty Pipeline and use a handler to do the batching. A marker message is used to signal the flushing.

Related to changes #3848 and #3837

lhotari avatar May 28 '24 23:05 lhotari

@lhotari some tests broke, e.g.

Error:  Errors: 
Error:  org.apache.bookkeeper.client.BookKeeperTest.testReadWriteWithV2WireProtocol
Error:    Run 1: BookKeeperTest.testReadWriteWithV2WireProtocol » BKNotEnoughBookies Not enough non-faulty bookies available
Error:    Run 2: BookKeeperTest.testReadWriteWithV2WireProtocol » BKNotEnoughBookies Not enough non-faulty bookies available
Error:    Run 3: BookKeeperTest.testReadWriteWithV2WireProtocol » BKNotEnoughBookies Not enough non-faulty bookies available

dlg99 avatar May 30 '24 23:05 dlg99

reopen's reason: rerun failure checks

StevenLuMT avatar Feb 15 '25 23:02 StevenLuMT