bookkeeper
bookkeeper copied to clipboard
[Test] migrate-junit5-client-module and parameterized beforeEach
Main Issue: #4322
1. why parameterized beforeEach
Because the current version of Junit 5 does not support class-level parameterized, related links,We can achieve the same effect by beforeEach。
2. Short-term solutions(this pr)
Refer to this post custom ParameterResolver and beforeEach implementations class-level parameterized
3. Long-term solutions
Keep up with the Junit5 community, and when Junit5 supports class-level parameterized, go with the official Junit5 way!
Test results
@shoothzj please help review
Overall looks good, can we use four indents in new code of
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/HandleFailuresTest.java?
sure😊
reopen's reason: rerun failure checks
CI is failing:
[INFO]
Error: Errors:
Error: org.apache.bookkeeper.client.TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter
Error: Run 1: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
Error: Run 2: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
Error: Run 3: TestMaxEnsembleChangeNum.testChangeEnsembleMaxNumWithWriter:46->MockBookKeeperTestCase.setBookKeeperConfig:253 » NullPointer
reopen's reason: rerun failure checks
testChangeEnsembleMaxNumWithWriter
@sherlock-lin take some time to deal with this issue.