Dylan T.
Dylan T.
My line of thought on this issue was to make getPickedItem() able to return NULL, but that requires a BC break.
> Do we keep a new interface which need to be included everywhere we have a BlockInventory or anything else come in your minds ? I think the whole thing...
Also worth asking if we really want to make an invasive change like this considering the upcoming #6533.
Closing this as I think the solution is way too complicated for the requirements.
I would also like to see this feature. I just never asked because I assumed it was coming sooner or later anyway (also my use case is small enough to...
Yep, ran into this problem in a bunch of places in PocketMine: https://github.com/pmmp/PocketMine-MP/actions/runs/10665106327/job/29557785290?pr=6441
It's because the knockback enchantment works separately to the damage knockback. This is by design (if I remember correctly) because the enchantment is supposed to add extra knockback, not override...
The problem isn't getting the knockback values into the event. The problem is integrating it with the existing knockback, as I said. Currently it requires multiple knockBack() calls to work...
It's still using `created` by default, right? So the default behaviour of the action will still be suboptimal
Sadly local experiments with improved key structure didn't make a huge difference. It definitely improved things but not nearly as much as I'd hoped.