Dirkjan Ochtman comments

Results 3119 comments of


                                            Dirkjan Ochtman

Would it make sense to have a `Database::open_lossy`

I think this is less about the precise API and more about which preconditions should be met for the API to still allow access to a functional `Database`.

Would it make sense to have a `Database::open_lossy`

Another potential direction that mirrors something we have in rustls-native certs: yield both an `Option` and a `Vec` (or similar), and only yield `Some` for the database if the number...

fix(check): Adjust format of 'rustup check' to be like Cargo

> Overall, I'm mixed on the results and can see this going one in several directions Can you elaborate? What do you like/don't like? What potential directions do you see?

Bash completion install doc improvements

> This seems to be [assert-rs/trycmd#91](https://github.com/assert-rs/trycmd/issues/91) then. @djc Before resolving that issue, maybe we should just accept the hack and use `/` in the snapshots? Seems fine?

Improve filtering

Would be nice to split this into smaller commits/PRs so it has less stuff going on all in the same commit.

Is there a reason that `DateTime::num_days_in_month()` returns a `u8` instead of a `u32`?

Just practically, I'm not going to make semver-incompatible changes for this.

Add advisory for zipora undefined behavior

@bindiego are you okay with this advisory being published? @lewismosciski the RustSec project by policy typically requires maintainers to consent to advisories. If you're going to file lots of these,...

Add advisory for zipora undefined behavior

> One follow-up question: For future reference, what is the policy if a maintainer doesn't respond to a vulnerability report after a reasonable amount of time? Is publishing an advisory...

Style: Decide between `foo.rs` and `foo/mod.rs`

> I have a strong preference for foo.rs I feel like stating this without any rationale isn't very helpful to the discussion.

Style: Decide between `foo.rs` and `foo/mod.rs`

> So, I prefer using `foo.rs` just because I adopted the suggestions mentioned by that picture above. It's no matter for me that the `foo.rs` and the `foo/bar.rs` doesn't be...