Dirkjan Ochtman
Dirkjan Ochtman
I'm open to PRs for this stuff.
Yeah, I was thinking removal of this should potentially be conditional on adding the upstream API that could replace this.
Okay, that's fair. Let's kill it.
The following test passes for me: ```diff diff --git a/src/datetime/tests.rs b/src/datetime/tests.rs index 67bee104..7a09fc5f 100644 --- a/src/datetime/tests.rs +++ b/src/datetime/tests.rs @@ -1910,3 +1910,21 @@ fn nano_roundrip() { assert_eq!(nanos, nanos2); } } +...
I'd suggest having an `enum Transport { Curl, Reqwest }` (guarding the variants of the enum with Cargo features), a value of which must be passed into the API when...
That should also work.
> TBH, doing this would be ideal and it would be great if that would be possible. The downstream would have to decide that though as the async versions of...
Seems nice, but I'm only doing passive maintenance on this project right now. If someone wants to submit a PR for this (with proper commit hygiene etc) I'd be happy...
I'm happy to review a PR for this.
> What is the motivation for this change? It's been over a month at this point so I don't remember exactly, but IIRC I got quite confused while I was...