Dirkjan Ochtman comments

Results 2027 comments of


                                            Dirkjan Ochtman

Allow dependencies that only apply to specific cargo targets (bin, example, etc.)

@dmarcuse @alexreg have you made any progress since your last comments here?

Allow dependencies that only apply to specific cargo targets (bin, example, etc.)

@dmarcuse what you have so far looks good! For drawbacks and alternatives, it would be probably be useful to dig into what `require_features` currently does and how it would interact...

Parts of libcompiler_builtins are compiled as WX

Uh, I guess. Do you mean like this? ```diff diff --git a/build.rs b/build.rs index 25cc520..787906f 100644 --- a/build.rs +++ b/build.rs @@ -4172,8 +4172,6 @@ mod c { &[ "i386/ashldi3.S", "i386/ashrdi3.S",...

Parts of libcompiler_builtins are compiled as WX

I have no clue how I'd test that, but if you can guide me along maybe I can come up with something.

Option to show the type parameters of every instantiation of a function

This would be particularly useful for futures, where all await functions actually get listed as `std::future::from_generator::GenFuture::poll()`.

I18n

I'm excited about this PR and also very busy for the next few days, so please have some patience with me!

Iterating over elements of an iterator inside a macro moves the inner collection

Yeah, I guess we should maybe take a reference of whatever we're passing to the macro? Would you be able to submit a PR?

Iterating over elements of an iterator inside a macro moves the inner collection

I think this is the relevant PR: https://github.com/djc/askama/commit/230263711e7edb0110e1679f6d31353ba7cdc919. We may want to tweak that logic? Navigating whether we want to pass references or ownership is often tricky. I think it...

Iterating over elements of an iterator inside a macro moves the inner collection

https://github.com/djc/askama/commit/c7697cbd406dce0962618e99a6b78116b14fdb1c contains similar changes for the macro calling code, I think.

Multiple configs?

Askama really doesn't support this use case, and it's not clear if it makes sense to do so. One thing that we've briefly discussed would be to allow "offline" code...