Dirkjan Ochtman

Results 3119 comments of Dirkjan Ochtman

@tarcieri the (work) week is almost over, got some more time soon?

Yes, I think so.

> I'm not sure if that's relevant or essential to how `indicatif` is supposed to work; my guess would be that might be some regular line flushing technique; not entirely...

Going to close this as a duplicate of https://github.com/rust-lang/rustup/issues/247.

`--ignore` ends up being a list of advisory IDs so I don't think it was intended to do what you're trying to do anyway. Do you have the exact error...

> I'm not sure there's a CLI argument to disable the yanked package check, but it can be disabled in `audit.toml`: > > https://github.com/rustsec/rustsec/blob/main/cargo-audit/audit.toml.example#L34 The `Override for AuditCommand` code doesn't...

IMO `cfg`-style features (2) are kind of a crutch -- I wouldn't want apps (as in, ultimate downstreams producing a binary) to have to specify `cfg` features for every upstream...

> I think I've said this before but I feel like (3) mainly works well if we can expose a `CryptoProvider` trait or type in a long-term stable (1.0) crate...

You don't have to use the static today; you can call ClientConfig::builder_with_provider() to provide the builder directly. That's option 1, more or less, which might be a decent resting point...