Dirkjan Ochtman

Results 3119 comments of Dirkjan Ochtman

As @tottoto suggested in a previous comment (thought it might not be quite clear), released versions of rustls-platform-verifier don't have all the API in place to support additivity with native-roots...

(Please squash any changes from feedback into the original commit.)

Ah, sorry, I missed your last comment on that. I think I'm still willing to take this, although I want an extra opt-in Cargo feature (let's call it `wasm-bindgen-unstable`) and...

Converting this to draft to make it clear that this should not be merged yet.

Thanks -- want to submit a PR?

(If you rebase on `main`, the WASM failure in CI should go away.)

@jcbhmr as an experienced Rust maintainer, just wanted to say that I'm seeing all the repositories I'm participating in migrate to dtolnay/rust-toolchain.

If you submit a PR we can judge how much complexity it introduces.

I'm not convinced. Why do you need this? Alternatively, could you do `MultipleChoiceText(MultipleChoiceText)` with `struct MultipleChoiceText { numbering: Numbering, text: Vec }` instead? That should get you pretty close.

So this runs into a bunch of issues where the enum media type must match each of the variant template's media type, which I think is tricky to enforce correctly....