direwolf420
direwolf420
This is what is causing the Mod Sources freeze: https://github.com/tModLoader/tModLoader/blob/8ef29f1a7ec0aa7d7890d86ec98c81237d28239d/patches/tModLoader/Terraria/ModLoader/UI/UIModSourceItem.cs#L159-L161
This is just a "port" of this PR, right? #2173
Where is BirthdayParty.WorldClear normally called in vanilla, and why would a modder want to call it?
Can you test if this properly works when you have an ongoing party in world 1, leave, then go into world 2 without a party? And also, the same scenario...
This is now needed more than ever due to #2632 being merged. Vanilla references keybinds within the localization file, tml currently doesn't offer that for modded keybinds. Example: `"If your...
Can you add documentation to every public method touched in the PR? It would be really helpful for explaining what it does and how to use it. (Sample usage in...
+1 on symlink, works like a charm. Only downside is that if you use the github VS extension in your ExampleMod solution, it doesn't recognize the linked repo for it,...
For anyone who implements this fix, looks like `WorldGen.KillTile_GetItemDrops`, the if block with `includeLargeObjectDrops` needs to include modded chests and dressers somehow (and NOT use `GetChestItemDrop/GetDresserItemDrop`, those methods only work...
Did you figure out a solution?
Add documentation to ClearPortableBankProjectileTrackers, then it's mergeable imo!