Mathieu Pillard

Results 384 comments of Mathieu Pillard

We probably do want `/` though: it's a common way of naming branches, and it's used by dependabot among other things.

We should do a find-replace to work around this, cause we definitely want the `/`. Also we want to avoid `latest` as the branch name. @KevinMind to add the documentation...

I don't mind that if we have a solution for dependabot.

Shouldn't be tied to Fastly, since reviewers domain is not behind a CDN. That's a synchronous request which can take a while for large files (need to wait for autograph,...

@ioanarusiczki could you try with more files on dev & stage and report back ? With the URLs that failed please.

@wagnerand have reviewers seen this in production ?

This is probably dependent on what is in the denied names, so we should investigate. Engineers can play around this in a django shell on dev.

`DeniedName` is only used for collections names and user display names, so that's consistent. The list in dev does contain "🌠". When encoded in UTF-8 it does start with the...

Aaaand it's collations again. On dev: ```sql mysql> SHOW CREATE TABLE users_denied_name; +-------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Table | Create Table | +-------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | users_denied_name | CREATE TABLE `users_denied_name` ( `id` int NOT...