Mathieu Pillard

Results 384 comments of Mathieu Pillard

Per discussion in standup, it looks like we do want pre-review for partner. Plan is to: - Have a spike to investigate having multiple promoted groups for an add-on -...

Version previews (autogenerated theme previews), Add-on previews (screenshots uploaded by the developer) and custom icons are broken that way locally.

We'll have to play with aliases I suspect. Interestingly patch that regressed this removed some aliases for xpis, but on [dev/stage/prod we do use them](https://github.com/mozilla-it/webservices-infra/blob/main/amo/k8s/amo-proxy/configs/addons.conf.tpl) (leaving the previews/icons alone, they...

`guarded-addons` is no longer a thing and can go away, FYI. Files that we are referencing directly: - Theme previews (automatically generated, attached to a `Version` through `VersionPreview`). Typical URL:...

For files we are referencing directly: - Theme previews are under `{root_storage}/shared_storage/uploads/version-previews` - Add-on previews are under `{root_storage}/shared_storage/uploads/previews` - Icons are under `{root_storage}/shared_storage/uploads/addon_icons` - User avatars are under `{root_storage}/shared_storage/uploads/userpics` As...

> I've tried to avoid modifying the styling of existing elements (such as the rating and review body being pushed to the right, to afford more space for the icon),...

We should reference https://github.com/mozilla-it/webservices-infra/blob/main/amo/k8s/addons-server/values.yaml somewhere in the `cron` command code.

Locally, I got this in celery logs while reporting a force-disabled add-on: ``` ValueError: invalid literal for int() with base 10: '043dc640-71bb-4806-b328-186a97a9748d' The above exception was the direct cause of...

Ugly workaround we discussed during Office Hours: install deps in a dummy virtualenv and point vscode to that. Alternatively we could find ways to expose the docker container deps to...