addons icon indicating copy to clipboard operation
addons copied to clipboard

[Bug]: 502 error on manual approval for larger files

Open ioanarusiczki opened this issue 1 year ago • 2 comments

What happened?

This was intermittent and checked it for -stage before Fastly. But now I can reproduce it at all attempts, it's the manual approval of a larger file (>40MB)

at approval

What did you expect to happen?

Version is approved , but the error is displayed instead of the reviewer page.

Is there an existing issue for this?

  • [X] I have searched the existing issues

┆Issue is synchronized with this Jira Task

ioanarusiczki avatar Sep 19 '24 12:09 ioanarusiczki

Shouldn't be tied to Fastly, since reviewers domain is not behind a CDN. That's a synchronous request which can take a while for large files (need to wait for autograph, grabbing the signed content, move it on storage), it certainly shouldn't fail though...

diox avatar Sep 19 '24 12:09 diox

@ioanarusiczki could you try with more files on dev & stage and report back ? With the URLs that failed please.

diox avatar Sep 24 '24 14:09 diox

what throws the error -> in all cases add-on is approved but the 502 error is present

LastPass dev https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633559 stage https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633559

Yomikiri https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633560 https://reviewers.addons.allizom.org/en-US/reviewers/review/1031720

Emoji dev https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633563

stage dmitlichess addon https://reviewers.addons.allizom.org/en-US/reviewers/review/1031722

70mb extension (large image files) https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/633564

what did not throw the error

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/633561 15mb, Dashlane https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/633562 phantom 11 mb (lots of js files) https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/1031721 50 mb file (with large images)

ioanarusiczki avatar Oct 25 '24 11:10 ioanarusiczki

@wagnerand have reviewers seen this in production ?

diox avatar Oct 25 '24 11:10 diox

I forwarded the question to reviewers.

wagnerand avatar Oct 28 '24 10:10 wagnerand

I've seen the error happen on production as well

ialecse avatar Oct 28 '24 10:10 ialecse