Mathieu Pillard

Results 384 comments of Mathieu Pillard

We should note when this goes to prod to see if we noticed a difference in incoming reports.

All changes that land are available on dev within a few minutes of the issue being closed (and then are available on stage on Tuesday evening CET the week before...

Yeah dev frontend deploys are a bit broken right now following some changes in the way we deploy dev.

See https://github.com/mozilla/addons/issues/15870

This is because the default Django deletion confirmation view tries to show all objects and there are too many. We should probably add a generic workaround to our admin (possibly...

Or we could just soft-delete the query rules and hide them forever...

We can - that's what I'm suggesting above before my second comment, but Django would still load them all to try to cascade, so we'd have to work around that...

If we want to try to just customize the related instances shown on the confirmation page, that's doable via https://docs.djangoproject.com/en/4.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.get_deleted_objects. As I said I'm not sure it'd be enough because...

Playing with this locally, overriding `get_delete_object()` does seem to work. Once displaying the related results is bypassed, the deletion is actually fairly straightforward, only the 2 `DELETE` queries are left,...

Shown where, to whom ? Reviewers ? Developers ? Users ?