Denis Žoljom

Do we want to work on this, or can we close this issue?

Should we have a sniff for that, or maybe some kind of whitelist added in the `ruleset.xml` (if this is possible ofc) for this? Otherwise I'd like to close this...

Is this covered in Theme Sniffer @timelsass ? I have the strangest feeling it is.

A sniff for this has been merged and will be in the next release (0.2.0). I'll close this to clean up the issues a bit.

Oh, I haven't taken that into the account. Reopening and adding the necessary label 🙂

Ok, the `GlobalVariablesOverride` sniff will work in the templates (we didn't touch that), so I guess we're good on that front. > So what's left are incidental variables used in...

A discussion from the triage basically is in agreement with the comment by Juliette: > If so desired though, a better solution would be to extend the WPCS sniff, overload...

I think that prefix all globals sniff covers the use-case of multiple text domains. @jrfnl @justintadlock can you confirm this? If it's the case, we can close this issue 🙂

This is odd, as there is a list of allowed folders in the ruleset https://github.com/WPTRT/WPThemeReview/blob/8398440d097cbe9b02fc901e1bc1e42bb3d02266/WPThemeReview/ruleset.xml#L127-L140 So this should work out of the box if I'm not mistaken 🤔 Unless this...

I'll mention this to the twenty twenty team. Maybe they can just follow the standard practices and use `template-parts` instead.