Denis Žoljom

Results 295 comments of Denis Žoljom

@timelsass did you have the time to look over the review? If you want, I could pull your changes and see if I can help with this sniff 🙂

I've changed the milestone to 0.2.x. Once you'll have more time I'd love for you to finish the sniff. If you need any help just let me or Juliette know...

Hi, @timelsass can you just let us know if you wish to continue working on this sniff. If yes, can you rebase so that the checks on GH actions will...

I've assigned this for a later release, since we are lacking decision on this.

Triage resolution: We should add this as a sniff. The handbook should also be updated (there are parts with `No removing or modifying non-presentational hooks`, so no removing of the...

I kinda think that Travis is failing due to all the changes on develop branch of WPCS 😬

It's not because of PHPCS, it's because of WPCS. There is an effort to rewrite tons of it using new awesome utils written by @jrfnl. Not 100% sure why it...

I mean if it solves the current problem then you can update Travis script. But this is actually an excellent opportunity to start using utils here 🙂

Oh I was thinking of doing this myself (a separate task ofc) ^^

@aristath We have moved away from Travis to GH actions for CI checks. Can you rebase your PR so that we may see if the checks will pass?