WPThemeReview
WPThemeReview copied to clipboard
No wordpress.org allowed in Theme URI
[New sniff] No wordpress.org allowed in Theme URI
Rule type:
Error
Rule:
ERROR | Verify - in style.css that the Theme URI does not point to wordpress.org (with predefined list of themes which are exempt and live under the wordpressdotorg user or have a check based on Author name.
Rule as it is found in the handbook. There is no specific rule on this.
Theme check file covering this rule:
https://github.com/Otto42/theme-check/blob/master/checks/uri.php
Decision needed:
If we are striving to have rules for sniffs the following rule should be considered. Selling, credits, and links
- Using a WordPress.org Theme URI is reserved for official themes.
Notes for implementation:
- This sniff will rely on the WordPress_AbstractThemeSniff Class to get the $sniff_helper array.
- Testing will require that a style.css file is in the same folder as the test file.
To do:
- [ ] Decision and implementation to add the rule in the Theme Review handbook to the Requirements page.
- [ ] Create unit tests
- [ ] Create new sniff
- [ ] Adjust existing WPCS / PHPCS sniff and send in PR upstream.
- [ ] Add existing
sniffname
sniff to the ruleset.
I have this sniff ready to go, however it uses the $sniff_helper array from the proposed WordPress_AbstractThemeSniff class.
PR #60
Can we add underscores.me as well? It would block some placeholders.
Is this covered in Theme Sniffer @timelsass ? I have the strangest feeling it is.