Denis Žoljom

Results 295 comments of Denis Žoljom

@WraithKenny there is just one small error I'm seeing in the actions run ```bash FILE: WPThemeReview/Sniffs/Plugins/CorrectTGMPAVersionSniff.php ---------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------- 203 | ERROR | Empty line...

Triage resolution: This should be added to the checks. The initial list from the theme check can be used and it can be expanded on. @ernilambar mentioned `wp-vcd.php`, not sure...

We are not including that standard atm, but I'm for it 👍 Anything that helps with the security is ok in my book 🙂

Do we have an estimate when this new release would be, because if it's too far in the future maybe it wouldn't be a bad thing to have this sniff...

Is this something we want to work on, any volunteers? Or should I leave this for the Theme Sniffer?

Valid points! Will put this for next major version milestone 👍 Good point about shorthand ternary. Tbh I almost never used it (I use null coalesce most of the time),...

Yes, it makes sense. I've moved the milestone so we can work on this after 0.2.1 is released 🙂

I don't think we have a PR on this, so I'll remove that tag. This sniff can go in a next release (after 0.2.0)

I asked about ESLint config options back in November https://github.com/squizlabs/PHP_CodeSniffer/issues/1210. So far it's added as a feature request, I don't see why they don't use rmccue's sniff for it (he...

@grappler I used it for a little while, but it has to be manually configured to work properly so I kinda... delayed it xD I'll be going through the WP...