Denis Žoljom

Results 368 comments of Denis Žoljom
trafficstars

I'm currently going through https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ and creating a `eslint.config.json` file. When I'm done with it, should I post it here?

Ok, I've gone through the rules and I have made `eslint.config.json` file: ~~~JSON { "root": true, "globals": { "_": false, "$": false, "Backbone": false, "JSON": false, "jQuery": false, "wp": false...

True, I will see which lints are checking for non coding style issues and create a new config that should be suitable for TRCS. The lints such as `no-empty-function` will...

Ok, a new config that would be suitable for TR is here: ~~~JSON { "root": true, "globals": { "_": false, "$": false, "Backbone": false, "JSON": false, "jQuery": false, "wp": false...

Oh, didn't know about the `no-eval()` rule. I've never used it or seen it being used in theme creation, which is why I didn't think that it's important. I can...

Well, a review would be good. Sure those can be set as a warning, but some are set as error based on the fact that you really shouldn't have useless...

So basically the lint rules for theme review should be only errors and only checking for faulty code. Any style resembling rules should be left out - like `curly`, `eqeqeq`...

I think that these rules could be considered as a 'base' that check against errors in code and unused vars and empty functions or conditionals (which is basically a garbage...

Nice article, but I didn't see any configuration files for ES lint ;) Plus we want to make a standard so that we can include it in the WPCS sniffs.

You can check the above discussion, and supplied lint configurations and see if there is something you think should be added :)