Bruno Dias

Results 274 comments of Bruno Dias

> React-Modal: Cannot register modal instance that's already open in Unknown :thinking: it must be failing to remove the instance from the manager.

My bad...I thought that the `h1` tag in the sandbox would not allow to trigger the suspense, but actually it comes from the LazyComponent. react-modal has a small manager to...

If suspense is been triggered, than it must create a new instance of the `Modal`, because that one was already "detroyed". https://github.com/reactjs/react-modal/blob/8a7426898cc53844dd2d3043e16d429a1a4942ad/src/helpers/portalOpenInstances.js#L9-L18 Unless react is doing some black magic to...

@oliverwatkins Can you make a reproducible example, please? That way it will be easy to debug.

Just to make sure this is the correct behavior... If I install the app in a folder '/path', all the links must resolve using the `baseUrl`, example: '/a' must resolve...

Nah...no problem. > I think including the baseUrl path with the navigate calls makes the most sense. You mean internally `navigate` will deal with it, or, the users will need...

I took the files from `tree-sitter-kotlin`. Let me know if I'm missing something.

Ping @amaanq. Let me know if there is something else that needs to be done in this PR.

@amaanq no problem. 👍

This is a fork of cmocka. I'd recommend to move this to the [upstream repository](https://gitlab.com/cmocka/cmocka).