Bruno Dias comments

Results 313 comments of


                                            Bruno Dias

* add cmake file

> > > > > > @jingyuexing Can you revert those formatting changes, please? > > > > Tested on macOS. > > Maybe you can create a action Yeah...I...

[Added] Modal Close on right click at overlay

We are going in the right direction, just made some comments. It must be the last change. Obrigado pelo PR.

[Added] Modal Close on right click at overlay

Awesome!! :tada: Can you include a test for this, please?

[Added] Modal Close on right click at overlay

It looks great, but we also need to add an unit testing for this feature. Let me know if you need anything...

[Added] Modal Close on right click at overlay

All unit tests are here https://github.com/reactjs/react-modal/tree/master/specs

How can I position my modal relative to a parent element in my component?

@cyruscuenca @C0DE-RUNNER @kaichii @exaucae Have you looked in the resultant style for the components involved?

How can I position my modal relative to a parent element in my component?

Thanks, @exaucae. can you explain this use case?

How can I position my modal relative to a parent element in my component?

Hmmm...I have seen this before. Using react-modal in this case is not the best option. Your solution looks great, I'd recommend extract this code to its own library or maybe...

'ReactModal' cannot be used as a JSX component.

@btraut @bokibo Can you provide the actual error that this version is throwing, please?

'ReactModal' cannot be used as a JSX component.

This is a typescript thing...it's very sad. I don't know how the react version is injected on the react-modal type definition, so I can't help. If you want to give...