Bruno Dias

Results 26 issues of Bruno Dias

Fixes #905. Changes proposed: - element with display 'contents' is visible and is tabbable. Upgrade Path (for changed or removed APIs): - None Acceptance Checklist: - [ ] The commit...

First, thanks for all the support through the years...reporting and answering issues, or submitting PRs. You guys are great. I try my best to find time to help improve this...

help wanted
discussion
styling
testing
refactoring
easy
accessibility

### Summary: This was noted on #847. ### Steps to reproduce: 1. fork this repository 2. change the react-modal's version to the fork's link on package.json e.g.`github.com/user/react-modal#branch` ### Expected behavior:...

bug
dependencies
build

We can't use window.HTMLElement to check the `appElement` when combined with an iframe. window.HTMLElement !== window.HTMLElement (on the iframe) Fixes #871. Changes proposed: - We can't use window.HTMLElement. Upgrade Path...

This library seems to have a nice api to fire events.

To keep things simple, each Modal can be placed on any level of the react's tree and it will do a proper clean up when it's time to unmount the...

feature
refactoring

`rspec-rails` uses the same core rspec libraries, but it seems that it is its own project. To avoid adding an extra dependency (rspec) on a project that already uses rspec-rails...

Hi, I'm not sure if there is a problem with my project's setup (rails app), but when I try to use this package I got an error like `cannot find...

This patch allows users to omit the short version of an option. Closes #24