Bruno Dias

Results 275 comments of Bruno Dias

Thanks, @bbugh. I'll give it a try.

I'm not sure if It would be a good idea since `rspec` e `rspec-rails`, they both use the same rspec "core" libraries, but they are 2 "different" projects...so, it should...

You can also extend `Rantly::Data`. ```rb require 'rantly/data' module Rantly::Data def state_and_city state = choose(*states) city = choose(*cities_within_state(state)) [state, city] end end property_of do state_and_city end ```

@honeymaro It depends. You should use `overlayRef` only if you need to do something with the reference. In this case, having 2 options is not a terrible idea.

@leaspark `shouldCloseOnOverlayClick` depends on `onRequestClose` because `react-modal` does not store the `isOpen` on its internal state. It's required so you can decide if the modal should be closed or display...

Hi @leaspark, did you find a way to fix your issue?

Why don't you fix it, @mleister97?

This seems to be a mem leak on the [src/helpers/portalOpenInstances.js](https://github.com/reactjs/react-modal/blob/master/src/helpers/portalOpenInstances.js), but it's most likely that this is caused by something that is holding the reference of a modal that should...

@brianpeiris Yep, this is not just a case of conditional rendering (but kinda related). The problem seems to be a new feature of react 18 where it can keep some...

@phayman Probably this library handles key events on their own, so maybe they are preventing the event to propagate (?)