Bruno Dias comments

Results 275 comments of


Bruno Dias

Display blurry when elements with position attributes and have scrollbars.

@renzhaoz Do you see this on all browsers?

Modal doesn't close on the first click on the overlay after click on elements containing event.stopPropagation() inside modal

@msubham193 go for it! Let me know if you need anything.

Modal doesn't close on the first click on the overlay after click on elements containing event.stopPropagation() inside modal

From what I saw, the issue actually is that either (or both) components - overlay and content, are receiving an event that is not theirs and they are setting up...

Modal doesn't close on the first click on the overlay after click on elements containing event.stopPropagation() inside modal

I've assigned to me to test the lateral buttons...but now I can't remove. This issue is free to anyone who want to work on it.

[chore] update readme and docs demos

> Remove the setAppElement example. A warning is now logged when the app element is not set so removed this one and instead setAppElement in all other demos. This needs...

Replace focus trap with `inert`

I'll be more conservative with this changes that relies on the browser. I mean, people that uses the browser are ok, but projects that links with different versions of webviews...

Replace shouldReturnFocusAfterClose={boolean} with returnFocusTo={Element}

@gautamz07 Take a look at this branch https://github.com/reactjs/react-modal/tree/v4 I think I've deprecated `shouldReturnFocusAfterClose` and need to add `returnFocusTo`.

Replace shouldReturnFocusAfterClose={boolean} with returnFocusTo={Element}

If you want, just go ahead and take over...

Bug: Modal with `closeTimeoutMS` unrecoverable with Suspense

@h3rmanj This is super weird...why is it triggering the fallback if there is still content been displayed? (the `h1` node)

Bug: Modal with `closeTimeoutMS` unrecoverable with Suspense

It is the lazy component that triggers the suspense. Probably, suspense uses conditional rendering on their side and react-modal doesn't play well with it.