kube-prometheus
kube-prometheus copied to clipboard
WIP: jsonnet: fix setting "platform" value
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Fixes #1285
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an x
in the box that apply.
- [ ]
CHANGE
(fix or feature that would cause existing functionality to not work as expected) - [ ]
FEATURE
(non-breaking change which adds functionality) - [X]
BUGFIX
(non-breaking change which fixes an issue) - [ ]
ENHANCEMENT
(non-breaking change which improves existing functionality) - [ ]
NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)
Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.
Fixed applying correct platform settings based on 'values.common.platform' value.
Do not merge this yet.
Looks like https://github.com/prometheus-operator/kube-prometheus/blob/main/examples/minikube.jsonnet#L21-L23 also need to be updated.
Also:
- https://github.com/prometheus-operator/kube-prometheus/blame/main/docs/migration-example/readme.md#L65-L67
- https://github.com/prometheus-operator/kube-prometheus/blob/main/docs/migration-example/my.release-0.8.jsonnet#L46-L48
Also:
- https://github.com/prometheus-operator/kube-prometheus/blame/main/docs/migration-example/readme.md#L65-L67
- https://github.com/prometheus-operator/kube-prometheus/blob/main/docs/migration-example/my.release-0.8.jsonnet#L46-L48
Those are about migrating to release-0.8
which uses kubePrometheus.platform
and not common.platform
. I am working on an internal logic for handling this.
Any chance this is going to be merged any time soon?
Sorry, I had to pause working on this for now and there are few cases where this still doesn't work.