Desi McAdam comments

Results 57 comments of


                                            Desi McAdam

PollingController.startPollingByNetworkClientId does not type-check the given options

@mcmire can you check if this is still an issue?

feat(`anvil`): option to persist all archive data

[Bug]: `MetaMetricsController: no userTraits found`

I am able to reproduce this on 12.10.0

Convert TokensController from BaseControllerV1 to BaseControllerV2

`hub` is used in Mobile in one place.

[Bug]: CCIP Read ENS resolution fails

@mirceanis Nope we are all good. Just missed closing the issue! It was included in 12.6.0

Some recent changelog entries are missing references to PRs

[Issue #150](https://github.com/MetaMask/auto-changelog/issues/150) will likely force a fix on this. Linking to verify.

Migrate libraries into core monorepo

browser-passworder, post-message-stream, web3-stream-provider — Not included because it's extension only Snap-related libraries (eth-snap-keyring, keyring-snaps-registry, snap-simple-keyring, snaps-registry) —not included because Snaps only. object-multiplex, swappable-obj-proxy, and safe-event-emitter - Not included because its...

[network-controller] Prevent inconsistent state during switch

We believe this is fixed now due to the changes with the NetworkController.

Behavior for `NetworkController.findNetworkClientIdByChainId` method/action is potentially surprising if more than one network has same chain ID

We believe we can fix the method now rather than deprecate it.

Behavior for `NetworkController.findNetworkClientIdByChainId` method/action is potentially surprising if more than one network has same chain ID

This might impact work on the Assets team.