Desi McAdam

Results 57 comments of Desi McAdam

@desi Look for old ticket around this and mark as duplicate once we do.

Main issue is that we aren't catching the error and because we aren't catching the error it is showing up in sentry but it shouldn't be. The second issue is...

This work may also need to be reflected on Extension as well.

Blocked by: https://github.com/MetaMask/accounts/issues/144

Maybe Use prototype branch Mark started. Maybe create a new one that is more minimal [The Controller Messager ADR ](https://github.com/MetaMask/decisions/blob/main/decisions/core/0001-messaging-non-controllers.md) should be implemented (easy but a large breaking change) ahead...

@kanthesha Will you take this one to see what the potential issues might be so we can do refinement on it?

@kanthesha should this be in "needs dev review"? Or "ready for dev"?

All of the steps above are correct. Rename to not be called Controller and remove it from using the BaseController class. Whoever picks this up should decide how to make...