metamask-extension icon indicating copy to clipboard operation
metamask-extension copied to clipboard
verified publisher icon MetaMask

[Bug]: CCIP Read ENS resolution fails

Open Gudahtt opened this issue 1 year ago • 3 comments

Describe the bug

Originally reported in https://github.com/MetaMask/eth-json-rpc-middleware/issues/335:

ENS resolution sometimes uses CCIP read (eip-3668) to resolve an address. That relies on a reverted execution being interpreted as a redirect. When the provider used to perform such a read is managed by this middleware, the read operation fails. My guess is that the reverted execution is somehow wrapped such that the error is no longer interpretable.

Expected behavior

ENS resolution should succeed, including addresses that use CCIP read.

Screenshots/Recordings

No response

Steps to reproduce

  1. Checkout the test-app repository locally to the ens-resolution branch (see https://github.com/MetaMask/test-dapp/pull/362)
  2. Start the test dapp using yarn start
  3. Install the MetaMask extension (any type of build)
  4. Ensure that the current selected chain is Ethereum Mainnet
  5. Navigate to the locally-hosted test dapp and connect at least one account
  6. Scroll to the bottom, enter jwt.ro into the "ENS Resolution" field, then click Submit

This should resolve to an address, but it currently resolves to null instead.

Error messages or log output

No response

Detection stage

In production (default)

Version

12.1.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Gudahtt avatar Oct 11 '24 00:10 Gudahtt

@Gudahtt We'll need https://github.com/MetaMask/metamask-extension/pull/22875

Blocked by: https://github.com/MetaMask/core/pull/4773 https://github.com/MetaMask/metamask-extension/pull/24496 https://github.com/MetaMask/metamask-extension/pull/27700

FrederikBolding avatar Oct 14 '24 14:10 FrederikBolding

plz fiz this, PizzaDAO needs you. We'll buy pizza for whoever does it!

snackman avatar Oct 14 '24 15:10 snackman

  • https://github.com/MetaMask/metamask-extension/pull/22875

Also related:

  • https://github.com/MetaMask/core/pull/4769
    • https://github.com/MetaMask/eth-json-rpc-infura/pull/114
    • https://github.com/MetaMask/providers/pull/380

legobeat avatar Oct 18 '24 03:10 legobeat

looks like #22875 fixed it

mirceanis avatar Oct 21 '24 13:10 mirceanis

This issue has been fixed. Are we waiting for a release to close it?

cc @mikesposito @Gudahtt

mirceanis avatar Oct 31 '24 16:10 mirceanis

@mirceanis Nope we are all good. Just missed closing the issue! It was included in 12.6.0

desi avatar Nov 14 '24 17:11 desi