Desi McAdam comments

Results 57 comments of


                                            Desi McAdam

Merge Extension AccountsTrackerController with the core one

Notes: Extension has support for single call balances contract to do a balance update with a single call and we need that feature on the one on core.

Introduce new process for entering changelog entries prior to release PR

We need documentation, update the PR template to include this in the check list, make a general announcement about this and push back on PRs that aren't doing this.

Add smoke tests for CommonJS and ESM builds for each package

- test that importing all exports doesn't crash. - no typescript settings

Convert MMIController to a non-controller (without renaming it)

We should tag the MMI team to discuss further if this feels like the right path forward.

Make SafeEventEmitterProvider type-compatible with Ethereum request libraries

Refer to technical proposal located in notion. If you can't find it ask @desi or @mcmire

`Contract` class `balances` method calls are typed as implicit `any`

The reason this type isn't defined is because those methods of that object are defined dynamically based on the abi. Presumably the ethers contract class doesn't type the response based...

`Contract` class `balances` method calls are typed as implicit `any`

Probably should at least add a comment explaining why the balances method exists and how we know that it is there and can be called so it isn't confusing in...