Patrik Ragnarsson

> I have not yet heard of other people having this issue besides you or other truffleruby developers. ?? – I'm no truffleruby developer :) Just a developer doing things...

I'm going to close this one, and recommend use of https://github.com/twingly/twingly-url (or your own wrapper) if you want this. While it has a strange name (hehe) it does this and...

This doesn't reproduce anymore, closing ```ruby irb(main):004:0> Addressable::VERSION::STRING => "2.8.1" irb(main):005:0> Addressable::URI.parse("http://example.com%C2").display_uri => # irb(main):006:0> Addressable::URI.unencode("http://%D5.example.com") => "http://\xD5.example.com" ``` Probably due to the changes made in https://github.com/sporkmonger/addressable/pull/459

I'm not getting ignoring to work with GitHub. Maybe they doesn't support suppressions in the uploaded SARIF? I can see the warning being in `ignored_warnings` in the regular Brakeman JSON...

> Maybe they doesn't support suppressions in the uploaded SARIF? That is the case: https://github.com/github/codeql-action/issues/1230#issuecomment-1235422738

Thanks @walro I'm indeed not seeing it if I start my app with `error_highlight ` disabled: `RUBYOPT=--disable-error_highlight bundle exec puma -p 5000 -e production` Looks like we are not the...

Sinatra 3.0.0 that includes https://github.com/sinatra/sinatra/pull/1519 (that addresses this) has been released, closing.

I've seen this being done by adding behavior to the [`setup_default_middleware`](https://github.com/sinatra/sinatra/blob/e69b6b9dee7165d3a583fc8a6af10ceee1ea687d/lib/sinatra/base.rb#L1692-L1700) method See https://github.com/rapid7/metasploit-framework/pull/12980/files#diff-450c1438fd1939e93afa67f321933d2b44a8b254ad6ce4616d08269588b623e6 for the example I tried it myself over at https://github.com/dentarg/gists/tree/10d569f00b83d549395c18a4cb87462670b91e1c/gists/sinatra-insert-middleware and it seems to work still...

@maryam-b I think it is safe to assume this bug is open for taking (label "help wanted" and no real activity here)

@jkowens https://github.com/sinatra/sinatra/pull/1805 was supposed to close this issue but GitHub does not support "Closes NNN and YYY" syntax that was used :) So please close it :)