sinatra icon indicating copy to clipboard operation
sinatra copied to clipboard

sinatra-reloader fails to reload controller with streaming wrapper

Open troex opened this issue 6 years ago • 4 comments

I have a wrapper method to stream requests like this https://gist.github.com/troex/31790323fb4a8a29c8b8cd84e50ad1e8

the reload works in the sample '/test_stream' method, but if I create another class and inherit it from MyController it will not reload any stream methods while regular get/post methods reload without issue.

Any ideas if I'm doing something wrong or it's a bug?

troex avatar Jan 25 '18 23:01 troex

@namusyaka Is this open for taking? is this a bug? would be great to know if we can work on it.

maryam-b avatar Oct 19 '18 18:10 maryam-b

@maryam-b I think it is safe to assume this bug is open for taking (label "help wanted" and no real activity here)

dentarg avatar Oct 20 '18 13:10 dentarg

@maryam-b Sorry for the late. Yes, this issue is still open.

We need to reproduce this bug as a first step. If this bug can be reproduced, we shoud write a test and fix it.

I would appreciate if you can work on this issue.

Thanks,

namusyaka avatar Oct 22 '18 04:10 namusyaka

@namusyaka okay then start working on it.

maryam-b avatar Oct 22 '18 09:10 maryam-b

@jkowens https://github.com/sinatra/sinatra/pull/1805 was supposed to close this issue but GitHub does not support "Closes NNN and YYY" syntax that was used :) So please close it :)

dentarg avatar Aug 25 '22 09:08 dentarg